Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @dmathieu as an approver #2908

Merged
merged 1 commit into from
May 18, 2022
Merged

Add @dmathieu as an approver #2908

merged 1 commit into from
May 18, 2022

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented May 17, 2022 •
edited by MrAlias
Loading

Requirements

@MadVikingGod MadVikingGod added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 17, 2022
MrAlias
MrAlias approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guessing the lint error is because @dmathieu is not added to the approvers team yet(?)

@dmathieu
Copy link
Member Author

It seems like goreportcard.com is having timeouts?

@dmathieu
Copy link
Member Author

I triggered a different sha for the commit, which reran the links build, and it now passes.

@MrAlias MrAlias merged commit a496d22 into open-telemetry:main May 18, 2022
@MrAlias MrAlias mentioned this pull request May 18, 2022
Merged
@dmathieu dmathieu deleted the dmathieu-approver branch May 18, 2022 17:44
@MrAlias MrAlias added this to the Release v1.8.0 milestone Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadVikingGod MadVikingGod MadVikingGod approved these changes

@MrAlias MrAlias MrAlias approved these changes

@XSAM XSAM XSAM approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@jmacd jmacd Awaiting requested review from jmacd

@evantorrie evantorrie Awaiting requested review from evantorrie

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
Release v1.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dmathieu @MadVikingGod @MrAlias @XSAM