Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into new_sdk/main #2913

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
0f3ab76
Rename all test funcs that mix camel and snake (#2788)
MrAlias Apr 15, 2022
1884de2
Add semconv/v1.8.0 (#2763)
MrAlias Apr 16, 2022
a8ea3db
Replace use of old term label with attribute (#2790)
MrAlias Apr 18, 2022
8574d43
Add semconv/v1.9.0 package (#2792)
bradtopol Apr 18, 2022
e8fbfd3
Update Link Checking and Markdown Linting Workflows (#2795)
MrAlias Apr 19, 2022
bcc5caa
Add vanity-import-fix make target (#2836)
MrAlias Apr 20, 2022
5f51565
Stop Benchmark Workflow from failing on alert (#2839)
TylerHelmuth Apr 20, 2022
f0a727e
Move unreleased semconv pkgs to unreleased section (#2843)
MrAlias Apr 21, 2022
c05c3e2
Add semconv/v1.10.0 (#2842)
MrAlias Apr 22, 2022
8982a14
Create an Inmemory Exporter for test (#2776)
MadVikingGod Apr 24, 2022
e3c8c74
Bump go.opentelemetry.io/proto/otlp from 0.15.0 to 0.16.0 in /exporte…
dependabot[bot] Apr 24, 2022
68d538a
Bump go.opentelemetry.io/proto/otlp from 0.15.0 to 0.16.0 in /exporte…
dependabot[bot] Apr 24, 2022
1ec851e
Bump google.golang.org/grpc from 1.45.0 to 1.46.0 in /exporters/otlp/…
dependabot[bot] Apr 25, 2022
907be79
Bump google.golang.org/grpc from 1.45.0 to 1.46.0 in /exporters/otlp/…
dependabot[bot] Apr 25, 2022
99cd89d
Bump codecov/codecov-action from 3.0.0 to 3.1.0 (#2846)
dependabot[bot] Apr 25, 2022
1eef145
Bump peter-evans/create-issue-from-file from 3 to 4 (#2847)
dependabot[bot] Apr 25, 2022
b8e4241
[docs] update resource initialization (#2844)
cartermp Apr 25, 2022
fdfc821
Add godot linter to golangci (#2845)
MrAlias Apr 25, 2022
d342bde
Fix a bug in example/fib/app.go line:69 (#2860)
Frapschen Apr 26, 2022
776accd
Remove unneeded metrictest types (#2864)
MrAlias Apr 27, 2022
a50cf6a
Release v1.7.0 (#2869)
MrAlias Apr 28, 2022
a14ecc7
Remove unnecessary internal package for noop instances (#2867)
bogdandrutu Apr 28, 2022
a9a5192
Move metric no-op implementation to metric package (#2866)
Apr 28, 2022
28aecfc
Fix license header check (#2870)
MrAlias Apr 29, 2022
789a433
Bump github/codeql-action from 1 to 2 (#2876)
dependabot[bot] May 2, 2022
c7cf945
Bump github.com/google/go-cmp from 0.5.7 to 0.5.8 (#2875)
dependabot[bot] May 2, 2022
b51c221
Integrate go-build-tools crosslink (#2886)
bryan-aguilar May 6, 2022
a0bed80
Change @paivagustavo to emeritus status (#2888)
MrAlias May 6, 2022
2a02a55
Add span status and error recording subsections to trace docs (#2893)
cartermp May 10, 2022
4475aaa
Create README.md for the ot bridge (#2896)
jkwatson May 17, 2022
a496d22
add @dmathieu as an approver (#2908)
dmathieu May 18, 2022
f127a15
Bump google.golang.org/grpc from 1.46.0 to 1.46.2 in /exporters/otlp/…
dependabot[bot] May 18, 2022
82cf8ad
Bump google.golang.org/grpc from 1.46.0 to 1.46.2 in /exporters/otlp/…
dependabot[bot] May 18, 2022
c5809aa
Bump github.com/prometheus/client_golang from 1.12.1 to 1.12.2 in /ex…
dependabot[bot] May 18, 2022
a7d8592
Merge branch 'main' into new_sdk/main
MrAlias May 18, 2022
77f9f08
Removed merge leftover
MrAlias May 19, 2022
e591cca
Use opentracing bridge from main
MrAlias May 19, 2022
2396e1c
go mod tidy
MrAlias May 19, 2022
84e52ec
crosslink
MrAlias May 19, 2022
c7f26ed
Remove Prometheus exporter from README for now
MrAlias May 19, 2022
8ac0588
Run make with new tool set
MrAlias May 19, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,5 @@ jobs:
output-file-path: output.txt
external-data-json-path: ./benchmarks/data.json
auto-push: false
fail-on-alert: true
fail-on-alert: false
alert-threshold: "400%"
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:
cp coverage.txt $TEST_RESULTS
cp coverage.html $TEST_RESULTS
- name: Upload coverage report
uses: codecov/codecov-action@v3.0.0
uses: codecov/codecov-action@v3.1.0
with:
file: ./coverage.txt
fail_ci_if_error: true
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ jobs:

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v1
uses: github/codeql-action/init@v2
with:
languages: go

- name: Autobuild
uses: github/codeql-action/autobuild@v1
uses: github/codeql-action/autobuild@v2

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v1
uses: github/codeql-action/analyze@v2

16 changes: 16 additions & 0 deletions .github/workflows/links-fail-fast.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Links (Fail Fast)

on:
push:
pull_request:

jobs:
check-links:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3

- name: Link Checker
uses: lycheeverse/lychee-action@v1.4.1
with:
fail: true
27 changes: 27 additions & 0 deletions .github/workflows/links.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Links

on:
repository_dispatch:
workflow_dispatch:
schedule:
# Everyday at 9:00 AM.
- cron: "0 9 * * *"

jobs:
check-links:
runs-on: ubuntu-latest
steps:
- name: Checkout Repo
uses: actions/checkout@v3

- name: Link Checker
id: lychee
uses: lycheeverse/lychee-action@v1.4.1

- name: Create Issue From File
if: steps.lychee.outputs.exit_code != 0
uses: peter-evans/create-issue-from-file@v4
with:
title: Link Checker Report
content-filepath: ./lychee/out.md
labels: report, bot-generated
34 changes: 34 additions & 0 deletions .github/workflows/markdown-fail-fast.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: Markdown (Fail Fast)

on:
push:
pull_request:

jobs:
changedfiles:
name: changed files
runs-on: ubuntu-latest
outputs:
md: ${{ steps.changes.outputs.md }}
steps:
- name: Checkout Repo
uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Get changed files
id: changes
run: |
echo "::set-output name=md::$(git diff --name-only --diff-filter=ACMRTUXB origin/${{ github.event.pull_request.base.ref }} ${{ github.event.pull_request.head.sha }} | grep .md$ | xargs)"

lint:
name: lint markdown files
runs-on: ubuntu-latest
needs: changedfiles
if: ${{needs.changedfiles.outputs.md}}
steps:
- name: Checkout Repo
uses: actions/checkout@v3
- name: Run linter
uses: docker://avtodev/markdown-lint:v1
with:
args: ${{needs.changedfiles.outputs.md}}
68 changes: 21 additions & 47 deletions .github/workflows/markdown.yml
Original file line number Diff line number Diff line change
@@ -1,57 +1,31 @@
name: markdown
name: Markdown

on:
push:
branches:
- main
pull_request:
jobs:
changedfiles:
name: changed files
runs-on: ubuntu-latest
outputs:
md: ${{ steps.changes.outputs.md }}
steps:
- name: Checkout Repo
uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Get changed files
id: changes
run: |
echo "::set-output name=md::$(git diff --name-only --diff-filter=ACMRTUXB origin/${{ github.event.pull_request.base.ref }} ${{ github.event.pull_request.head.sha }} | grep .md$ | xargs)"
repository_dispatch:
workflow_dispatch:
schedule:
# Everyday at 9:00 AM.
- cron: "0 9 * * *"

lint:
name: lint markdown files
jobs:
lint-markdown:
runs-on: ubuntu-latest
needs: changedfiles
if: ${{needs.changedfiles.outputs.md}}
steps:
- name: Checkout Repo
uses: actions/checkout@v3

- name: Run linter
id: markdownlint
uses: docker://avtodev/markdown-lint:v1
with:
args: ${{needs.changedfiles.outputs.md}}
config: .markdownlint.yaml
args: '**/*.md'
output: ./markdownlint.txt

check-links:
runs-on: ubuntu-latest
needs: changedfiles
if: ${{needs.changedfiles.outputs.md}}
steps:
- name: Checkout Repo
uses: actions/checkout@v3
with:
fetch-depth: 0
# This doesn't use gaurav-nelson/github-action-markdown-link-check
# intentionally. As of v1.0.13 the base image was not pinned to a LTS
# version of node and updates upstream to the base image caused CI
# failures. This boils down the entrypoint script from that repository
# and calls markdown-link-check directly instead.
- name: Install markdown-link-check
run: npm install -g markdown-link-check
- name: Run markdown-link-check
run: |
markdown-link-check \
--verbose \
--config .markdown-link.json \
${{needs.changedfiles.outputs.md}}
- name: Create Issue From File
if: steps.markdownlint.outputs.exit_code != 0
uses: peter-evans/create-issue-from-file@v4
with:
title: Markdown Lint Report
content-filepath: ./markdownlint.txt
labels: report, bot-generated
7 changes: 7 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ linters:
- goimports
- gosimple
- govet
- godot
- ineffassign
- misspell
- revive
Expand Down Expand Up @@ -45,3 +46,9 @@ linters-settings:
- cancelled
goimports:
local-prefixes: go.opentelemetry.io
godot:
exclude:
# Exclude sentence fragments for lists.
- '^[ ]*[-•]'
# Exclude sentences prefixing a list.
- ':$'
2 changes: 2 additions & 0 deletions .lycheeignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
http://localhost
http://jaeger-collector
20 changes: 0 additions & 20 deletions .markdown-link.json

This file was deleted.

47 changes: 43 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,49 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

## [Unreleased]

### Changed

- The `crosslink` make target has been updated to use the `go.opentelemetry.io/build-tools/crosslink` package. (#2886)

## [1.7.0/0.30.0] - 2022-04-28

### Added

- Add the `go.opentelemetry.io/otel/semconv/v1.8.0` package.
The package contains semantic conventions from the `v1.8.0` version of the OpenTelemetry specification. (#2763)
- Add the `go.opentelemetry.io/otel/semconv/v1.9.0` package.
The package contains semantic conventions from the `v1.9.0` version of the OpenTelemetry specification. (#2792)
- Add the `go.opentelemetry.io/otel/semconv/v1.10.0` package.
The package contains semantic conventions from the `v1.10.0` version of the OpenTelemetry specification. (#2842)
- Added an in-memory exporter to metrictest to aid testing with a full SDK. (#2776)

### Fixed

- Delegated instruments are unwrapped before delegating Callbacks. (#2784)
- Resolve supply-chain failure for the markdown-link-checker GitHub action by calling the CLI directly. (#2834)
- Remove import of `testing` package in non-tests builds. (#2786)
- Globally delegated instruments are unwrapped before delegating asynchronous callbacks. (#2784)
- Remove import of `testing` package in non-tests builds of the `go.opentelemetry.io/otel` package. (#2786)

### Changed

- The `WithLabelEncoder` option from the `go.opentelemetry.io/otel/exporters/stdout/stdoutmetric` package is renamed to `WithAttributeEncoder`. (#2790)
- The `LabelFilterSelector` interface from `go.opentelemetry.io/otel/sdk/metric/processor/reducer` is renamed to `AttributeFilterSelector`.
The method included in the renamed interface also changed from `LabelFilterFor` to `AttributeFilterFor`. (#2790)
- The `Metadata.Labels` method from the `go.opentelemetry.io/otel/sdk/metric/export` package is renamed to `Metadata.Attributes`.
Consequentially, the `Record` type from the same package also has had the embedded method renamed. (#2790)
- Move metric no-op implementation form `nonrecording` to `metric` package. (#2866)

### Deprecated

- The `Iterator.Label` method in the `go.opentelemetry.io/otel/attribute` package is deprecated.
Use the equivalent `Iterator.Attribute` method instead. (#2790)
- The `Iterator.IndexedLabel` method in the `go.opentelemetry.io/otel/attribute` package is deprecated.
Use the equivalent `Iterator.IndexedAttribute` method instead. (#2790)
- The `MergeIterator.Label` method in the `go.opentelemetry.io/otel/attribute` package is deprecated.
Use the equivalent `MergeIterator.Attribute` method instead. (#2790)

### Removed

- Removed the `Batch` type from the `go.opentelemetry.io/otel/sdk/metric/metrictest` package. (#2864)
- Removed the `Measurement` type from the `go.opentelemetry.io/otel/sdk/metric/metrictest` package. (#2864)

## [0.29.0] - 2022-04-11

Expand Down Expand Up @@ -1819,7 +1857,8 @@ It contains api and sdk for trace and meter.
- CircleCI build CI manifest files.
- CODEOWNERS file to track owners of this project.

[Unreleased]: https://github.com/open-telemetry/opentelemetry-go/compare/metric/v0.29.0...HEAD
[Unreleased]: https://github.com/open-telemetry/opentelemetry-go/compare/v1.7.0...HEAD
[1.7.0/0.30.0]: https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.7.0
[0.29.0]: https://github.com/open-telemetry/opentelemetry-go/releases/tag/metric/v0.29.0
[1.6.3]: https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.6.3
[1.6.2]: https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.6.2
Expand Down
2 changes: 1 addition & 1 deletion CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
# https://help.github.com/en/articles/about-code-owners
#

* @jmacd @MrAlias @Aneurysm9 @evantorrie @XSAM @dashpole @paivagustavo @MadVikingGod @pellared @hanyuancheung
* @jmacd @MrAlias @Aneurysm9 @evantorrie @XSAM @dashpole @MadVikingGod @pellared @hanyuancheung @dmathieu

CODEOWNERS @MrAlias @Aneurysm9 @MadVikingGod
6 changes: 5 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -506,16 +506,20 @@ Approvers:
- [Josh MacDonald](https://github.com/jmacd), LightStep
- [Sam Xie](https://github.com/XSAM), Cisco/AppDynamics
- [David Ashpole](https://github.com/dashpole), Google
- [Gustavo Silva Paiva](https://github.com/paivagustavo), LightStep
- [Robert Pająk](https://github.com/pellared), Splunk
- [Chester Cheung](https://github.com/hanyuancheung), Tencent
- [Damien Mathieu](https://github.com/dmathieu), Auth0/Okta

Maintainers:

- [Aaron Clawson](https://github.com/MadVikingGod), LightStep
- [Anthony Mirabella](https://github.com/Aneurysm9), AWS
- [Tyler Yahn](https://github.com/MrAlias), Splunk

Emeritus:

- [Gustavo Silva Paiva](https://github.com/paivagustavo), LightStep

### Become an Approver or a Maintainer

See the [community membership document in OpenTelemetry community
Expand Down
16 changes: 10 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ TIMEOUT = 60
.DEFAULT_GOAL := precommit

.PHONY: precommit ci
precommit: dependabot-generate license-check misspell go-mod-tidy golangci-lint-fix test-default
precommit: dependabot-generate license-check vanity-import-fix misspell go-mod-tidy golangci-lint-fix test-default
ci: dependabot-check license-check lint vanity-import-check build test-default check-clean-work-tree test-coverage

# Tools
Expand All @@ -45,7 +45,7 @@ SEMCONVGEN = $(TOOLS)/semconvgen
$(TOOLS)/semconvgen: PACKAGE=go.opentelemetry.io/build-tools/semconvgen

CROSSLINK = $(TOOLS)/crosslink
$(TOOLS)/crosslink: PACKAGE=go.opentelemetry.io/otel/$(TOOLS_MOD_DIR)/crosslink
$(TOOLS)/crosslink: PACKAGE=go.opentelemetry.io/build-tools/crosslink

SEMCONVKIT = $(TOOLS)/semconvkit
$(TOOLS)/semconvkit: PACKAGE=go.opentelemetry.io/otel/$(TOOLS_MOD_DIR)/semconvkit
Expand Down Expand Up @@ -147,8 +147,8 @@ golangci-lint/%: | $(GOLANGCI_LINT)

.PHONY: crosslink
crosslink: | $(CROSSLINK)
@echo "cross-linking all go modules" \
&& $(CROSSLINK)
@echo "Updating intra-repository dependencies in all go modules" \
&& $(CROSSLINK) --root=$(shell pwd) --prune

.PHONY: go-mod-tidy
go-mod-tidy: $(ALL_GO_MOD_DIRS:%=go-mod-tidy/%)
Expand All @@ -166,15 +166,19 @@ lint: misspell lint-modules golangci-lint

.PHONY: vanity-import-check
vanity-import-check: | $(PORTO)
@$(PORTO) --include-internal -l .
@$(PORTO) --include-internal -l . || echo "(run: make vanity-import-fix)"

.PHONY: vanity-import-fix
vanity-import-fix: | $(PORTO)
@$(PORTO) --include-internal -w .

.PHONY: misspell
misspell: | $(MISSPELL)
@$(MISSPELL) -w $(ALL_DOCS)

.PHONY: license-check
license-check:
@licRes=$$(for f in $$(find . -type f \( -iname '*.go' -o -iname '*.sh' \) ! -path '**/third_party/*') ; do \
@licRes=$$(for f in $$(find . -type f \( -iname '*.go' -o -iname '*.sh' \) ! -path '**/third_party/*' ! -path './.git/*' ) ; do \
awk '/Copyright The OpenTelemetry Authors|generated|GENERATED/ && NR<=3 { found=1; next } END { if (!found) print FILENAME }' $$f; \
done); \
if [ -n "$${licRes}" ]; then \
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ All officially supported exporters for the OpenTelemetry project are contained i
| :-----------------------------------: | :-----: | :----: |
| [Jaeger](./exporters/jaeger/) | ||
| [OTLP](./exporters/otlp/) |||
| [Prometheus](./exporters/prometheus/) || |
| [stdout](./exporters/stdout/) |||
| [Zipkin](./exporters/zipkin/) | ||

Expand Down
Loading