Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metricdatatest package #3025

Merged
merged 41 commits into from
Jul 21, 2022
Merged

Add metricdatatest package #3025

merged 41 commits into from
Jul 21, 2022

Commits on Jul 11, 2022

  1. Use export.Aggregation instead of internal

    @MrAlias
    MrAlias committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    47c57bc View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. Return an export.Aggregation instead of a slice

    @MrAlias
    MrAlias committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    9e78415 View commit details
    Browse the repository at this point in the history

  2. Use attribute Sets instead of KeyValues for export data 

    Attribute Sets have stronger guarantees about the uniqueness of their
keys and more functionality. We already ensure attributes are stored as
Sets by the aggregator which will produce these data types. Instead of
converting to a KeyValue slice, keep the data as a Set.

Any user of the data can always call the ToSlice method to use the data
as a slice of KeyValues.
    @MrAlias
    MrAlias committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    f8ec18c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'data-attr-set' into agg-test-framework

    @MrAlias
    MrAlias committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    67fbfdd View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. Add export data type comparison testing API

    @MrAlias
    MrAlias committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    2f9d30d View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Add Aggregation and Value comparison funcs

    @MrAlias
    MrAlias committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    471f91a View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. Move export testing to own pkg

    @MrAlias
    MrAlias committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    522bdc0 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2022

  1. Merge branch 'new_sdk/main' into agg-test-framework

    @MrAlias
    MrAlias committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    c964ea5 View commit details
    Browse the repository at this point in the history

  2. Move exporttest to metricdatatest

    @MrAlias
    MrAlias committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    38558a0 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. Add licenses headers to files missing them

    @MrAlias
    MrAlias committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    e251fa5 View commit details
    Browse the repository at this point in the history

  2. Use metricdata instead of export 

    Fix merge of new_sdk/main
    @MrAlias
    MrAlias committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    041537b View commit details
    Browse the repository at this point in the history

  3. Rename exporttest pkg to metricdatatest

    @MrAlias
    MrAlias committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    b138608 View commit details
    Browse the repository at this point in the history

  4. Fix spelling errors

    @MrAlias
    MrAlias committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    ddb2850 View commit details
    Browse the repository at this point in the history

  5. Fix lint issues

    @MrAlias
    MrAlias committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    dea1b3a View commit details
    Browse the repository at this point in the history

  6. Use testing pkg to error directly 

    Include Helper() method calls to correct the call-stack.
    @MrAlias
    MrAlias committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    01c428c View commit details
    Browse the repository at this point in the history

  7. Fix CompareAggregations 

    Set equal to true by default
    @MrAlias
    MrAlias committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    fcf026e View commit details
    Browse the repository at this point in the history

  8. Generalize assertions and unexport equal checks

    @MrAlias
    MrAlias committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    1de2c4e View commit details
    Browse the repository at this point in the history

  9. Abstract assert tests

    @MrAlias
    MrAlias committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    4227e72 View commit details
    Browse the repository at this point in the history

  10. Rename all exp var to r

    @MrAlias
    MrAlias committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    93ac61f View commit details
    Browse the repository at this point in the history

  11. Test AssertAggregationsEqual

    @MrAlias
    MrAlias committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    755c900 View commit details
    Browse the repository at this point in the history

  12. Comment why Value and Aggregation are separate

    @MrAlias
    MrAlias committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    a932325 View commit details
    Browse the repository at this point in the history

  13. Test AssertValuesEqual

    @MrAlias
    MrAlias committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    aceec74 View commit details
    Browse the repository at this point in the history

  14. Revert changes to metricdata/temporality.go

    @MrAlias
    MrAlias committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    1c2f5d9 View commit details
    Browse the repository at this point in the history

  15. Expand pkg doc sentence

    @MrAlias
    MrAlias committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    f65075c View commit details
    Browse the repository at this point in the history

  16. Add license header to assertion.go

    @MrAlias
    MrAlias committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    3631507 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2022

  1. Update assertion docs

    @MrAlias
    MrAlias committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    0d26417 View commit details
    Browse the repository at this point in the history

  2. Consolidate comparisons funcs into one file

    @MrAlias
    MrAlias committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    85d1f60 View commit details
    Browse the repository at this point in the history

  3. Consolidate and fix docs

    @MrAlias
    MrAlias committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    ec7106d View commit details
    Browse the repository at this point in the history

  4. Consolidate assertion.go

    @MrAlias
    MrAlias committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    ddfe5b5 View commit details
    Browse the repository at this point in the history

  5. Consolidate comparisons.go

    @MrAlias
    MrAlias committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    9b50ea9 View commit details
    Browse the repository at this point in the history

  6. make lint

    @MrAlias
    MrAlias committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    3e61b4c View commit details
    Browse the repository at this point in the history

  7. Test with relatively static times

    @MrAlias
    MrAlias committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    6cce6a6 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. Update sdk/metric/metricdata/metricdatatest/comparisons.go 

    Co-authored-by: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com>
    @MrAlias @MadVikingGod
    MrAlias and MadVikingGod authored Jul 20, 2022
    Configuration menu
    Copy the full SHA
    65d0f1a View commit details
    Browse the repository at this point in the history

  2. Drop equal return from comparison funcs

    @MrAlias
    MrAlias committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    f70a5e5 View commit details
    Browse the repository at this point in the history

  3. Refactor AssertEqual

    @MrAlias
    MrAlias committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    0dec436 View commit details
    Browse the repository at this point in the history

  4. Remove reasN from testDatatype func params

    @MrAlias
    MrAlias committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    73e319c View commit details
    Browse the repository at this point in the history

  5. Consolidate AssertEqual type conversions

    @MrAlias
    MrAlias committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    9985b46 View commit details
    Browse the repository at this point in the history

  6. Fix assertion error message

    @MrAlias
    MrAlias committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    34c4d13 View commit details
    Browse the repository at this point in the history

  7. Add assertion failure tests

    @MrAlias
    MrAlias committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    f894686 View commit details
    Browse the repository at this point in the history

  8. Remove unneeded strings join

    @MrAlias
    MrAlias committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    82973be View commit details
    Browse the repository at this point in the history

  9. Make comment include a possessive

    @MrAlias
    MrAlias committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    6e54b91 View commit details
    Browse the repository at this point in the history