-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move exponential histogram mapping functions into top-level module #3159
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3159 +/- ##
=======================================
- Coverage 76.3% 76.2% -0.1%
=======================================
Files 180 180
Lines 11992 11992
=======================================
- Hits 9153 9149 -4
- Misses 2597 2601 +4
Partials 242 242
|
Note that we agreed to make public exponential-histogram mapping functions available in #2501; the code in |
If we accept this PR, I will apply the same change of path to #3022 -- the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think these packages have enough review or use to be included in a stable module just yet.
I think this package could fit into the new metric SDK.
FWIW, we are using these mapping functions extensively (and exclusively) inside Lightstep. |
The exponential histogram mapping functions are not SDK-specific and have been until now included in the
sdk/metric
module, which is being swapped soon. Removing this non-SDK component allows it to be released without disruption as the metrics SDK is replaced.Part of #2328 because that way the
sdk/metric/aggregator
directory can be removed completely.