Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
Span#RecordError
method to simplify adding error events to spans #473Add
Span#RecordError
method to simplify adding error events to spans #473Changes from all commits
96d77ed
d7c6561
1e4e454
5aa80ed
02fb7dc
50f19bc
a9a11ce
b3ae96c
9363960
2e932cb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line raises questions for me about the
SetStatus
API, which is tangential to this PR. The Span.Status field has two fields, the code (passed here) and a message. This should probably set the sameerr.Error()
as used for the event message, but theSetStatus
API doesn't accept a message string (which is a separate matter).This has me wondering whether we want to use
RecordError(..., WithStatusCode())
as the conventional pattern for recording an error and setting the status. I'm not sure I'd pick this approach -- I'm inclined for there to be two methods, one to record an error event, and one to record an error event plus set the status (i.e., two methodsRecordErrorEvent
andRecordErrorStatus
).