Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add otlploghttp exporter skeleton #5138

Merged
merged 9 commits into from
Apr 4, 2024
Merged

Add otlploghttp exporter skeleton #5138

merged 9 commits into from
Apr 4, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 3, 2024

Part of #5057

@MrAlias MrAlias added area:logs Part of OpenTelemetry logs Skip Changelog PRs that do not require a CHANGELOG.md entry pkg:exporter:otlp Related to the OTLP exporter package labels Apr 3, 2024
@MrAlias MrAlias mentioned this pull request Apr 3, 2024
Closed
15 tasks
@codecov Codecov
Copy link

codecov bot commented Apr 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 4.65116% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 83.7%. Comparing base (afb6af0) to head (8e48c3d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5138     +/-   ##
=======================================
- Coverage   83.9%   83.7%   -0.3%     
=======================================
  Files        248     252      +4     
  Lines      16383   16426     +43     
=======================================
+ Hits       13749   13751      +2     
- Misses      2345    2386     +41     
  Partials     289     289
Files Coverage Δ
exporters/otlp/otlplog/otlploghttp/version.go 100.0% <100.0%> (ø)
exporters/otlp/otlplog/otlploghttp/client.go 0.0% <0.0%> (ø)
exporters/otlp/otlplog/otlploghttp/exporter.go 0.0% <0.0%> (ø)
exporters/otlp/otlplog/otlploghttp/config.go 0.0% <0.0%> (ø)

@MrAlias MrAlias changed the title Add skelton for otlploghttp exporter Add otlploghttp exporter skeleton Apr 3, 2024
@MrAlias
Copy link
Contributor Author

MrAlias commented Apr 3, 2024

CI lint failure fixed by #5139

@MrAlias MrAlias marked this pull request as ready for review April 3, 2024 23:13
@pellared
Copy link
Member

pellared commented Apr 4, 2024 •
edited
Loading

Merging to keep to momentum. Also the PR has already 3 approvals, the Go module is not released, therefore I do not find it critical to delay merging.

@pellared pellared merged commit 14e3f6b into open-telemetry:main Apr 4, 2024
25 of 27 checks passed
@MrAlias MrAlias deleted the otlploghttp branch April 4, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared approved these changes

@dashpole dashpole dashpole approved these changes

@XSAM XSAM XSAM approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
area:logs Part of OpenTelemetry logs pkg:exporter:otlp Related to the OTLP exporter package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
Go: Logs (GA)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrAlias @pellared @dashpole @XSAM