Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Samplers to conform to Spec #531

Merged
merged 9 commits into from
Mar 10, 2020
Merged

Update Samplers to conform to Spec #531

merged 9 commits into from
Mar 10, 2020

Commits on Mar 9, 2020

  1. Refactor SDK Sampler API to conform to Spec 

    * Sampler is now an interface rather than a function type
* SamplingParameters include the span Kind, Attributes, and Links
* SamplingResult includes a SamplingDecision with three possible values, as well as Attributes
    @Aneurysm9
    Aneurysm9 committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    797bd35 View commit details
    Browse the repository at this point in the history

  2. Add attributes retruned from a Sampler to the span

    @Aneurysm9
    Aneurysm9 committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    e1ba4ea View commit details
    Browse the repository at this point in the history

  3. Add SpanKind, Attributes, and Links to API Sampler.ShouldSample() par… 

    …ameters
    @Aneurysm9
    Aneurysm9 committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    f2fe629 View commit details
    Browse the repository at this point in the history

  4. Drop "Get" from sdk Sampler.GetDescription to match api Sampler

    @Aneurysm9
    Aneurysm9 committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    de0257a View commit details
    Browse the repository at this point in the history

  5. Make spanID parameter in API Sampler interface a core.SpanID

    @Aneurysm9
    Aneurysm9 committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    78b2e73 View commit details
    Browse the repository at this point in the history

  6. Fix types and printf format per PR feedback from krnowak

    @Aneurysm9
    Aneurysm9 committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    e8d73e7 View commit details
    Browse the repository at this point in the history

  7. Ensure unit test error messages reflect new reality

    @Aneurysm9
    Aneurysm9 committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    9151237 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' of https://github.com/open-telemetry/openteleme… 

    …try-go into OTG-519
    @Aneurysm9
    Aneurysm9 committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    ba9d884 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Merge branch 'master' into OTG-519

    @jmacd
    jmacd authored Mar 10, 2020
    Configuration menu
    Copy the full SHA
    20399b2 View commit details
    Browse the repository at this point in the history