Refactor the api/metrics push controller; add CheckpointSet synchronization #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
Aneurysm9,
evantorrie,
lizthegrey,
MrAlias and
paivagustavo
as code owners
MrAlias
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From reviewing #735, it's not clear that the synchronization of the
*simple.Integratormap was correct, that it's possible for a reader-writer panic in the underlying map.The push controller directly refers to the
*simple.Integrator, and push options are added for settingStatefulandPeriod. The default push interval changes to 10s (from the pain of #735).Prometheus changes the result of
NewExportPipelineto*Exporterfromhttp.Handler. Adds a test for Prometheus statefulness and refactors existing mock clock code.This is preparatory for removing the push controller from the Prometheus exporter, adding a pull controller instead.