Fix panic in gRPC UnaryServerInfo #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey and
paivagustavo
as code owners
lizthegrey
reviewed
May 18, 2020
jmacd
approved these changes
May 18, 2020
vmihailenco
reviewed
May 19, 2020
| @@ -43,9 +43,29 @@ var ( | |||
| messageUncompressedSizeKey = kv.Key("message.uncompressed_size") | |||
There was a problem hiding this comment.
Should this be messaging.message_payload_size_bytes according to https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/messaging.md or these are unrelated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unresolved issue identified in #691 and attempted in #697.
Adds unit test to ensure the
UnaryServerInfofunction does not panic during an error returned from the handler and appropriately annotates the span with the correct event.Restructures the interceptor to remove this class of errors.
Actually Fixes #691