Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo] add grafana dashboards #734

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Apr 6, 2023

Adds the Spanmetrics and OpenTelemetry Collector Data Flow dashboards from the Demo repo.

Because we have multiple dashboards, and managing them in a single file is problematic, I used the (.Files.Glob "grafana-dashboards/*.json").AsConfig construct and store all the dashboard files in the respective subfolder instead.

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck puckpuck requested a review from a team April 6, 2023 05:38
Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: we should replace the spanmetricsprocessor with the spanmetricsconnector.

@puckpuck
Copy link
Contributor Author

puckpuck commented Apr 6, 2023

Side note: we should replace the spanmetricsprocessor with the spanmetricsconnector.

We plan to do so after Connectors get out of alpha state and don't require a feature gate to be enabled.

@dmitryax
Copy link
Member

dmitryax commented Apr 6, 2023

Going forward, maybe we can automate fetching the dashboards from the demo repo instead copy-pasting them? We solved a similar issue for the operator with update-operator-crds make target

@dmitryax dmitryax merged commit 84d9ebe into open-telemetry:main Apr 6, 2023
@puckpuck puckpuck deleted the demo.update_dashboards branch April 6, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants