Add ability to set your own common labels for all resources #814
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinrw
requested review from
dmitryax,
TylerHelmuth and
povilasv
as code owners
|
apologies for missing out the description, I've updated it now |
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| nameOverride: "" | |||
| fullnameOverride: "" | |||
|
|
|||
| commonLabels: {} | |||
There was a problem hiding this comment.
Please add a description the explains this field similar to https://github.com/prometheus-community/helm-charts/blob/8b91a619e9407c0e830df7071ee73cd160937b6b/charts/kube-prometheus-stack/values.yaml#L25-L27.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change gives us a new optional variable that we can set which allows you to add your own custom labels to all of the resources being deployed. Currently we are able to do this with Pods but not anything else like deployments, config-maps etc.
This is already quite common among many other open source helm charts. It fixes a problem for us where we use these labels for identifying which teams own certain resources which in turn helps us direct prometheus alerts to the correct teams.