Polished contributing docs #10299
Merged
Polished contributing docs #10299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
Jan 23, 2024
Used stronger wording instead of bolding. Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
|
Hi @trask @theletterf, for this PR, do you have any more suggestions? |
Use capital letters for further emphasis.
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
steverao
added a commit
to steverao/opentelemetry-java-instrumentation
that referenced
this pull request
Feb 16, 2024
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before I created the first PR #10258 to the repository, I saw the contributing docs. But there are still some code convention problems in my PR that they are not clearly written in the relevant docs. So I polished the relevant docs.