Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testIndy on main #11582

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Fix testIndy on main #11582

merged 5 commits into from
Jun 13, 2024

Conversation

JonasKunz
Copy link
Contributor

@JonasKunz JonasKunz commented Jun 13, 2024 •
edited
Loading

Looks like -PtestIndy=true is currently broken on main: There have been some modules added, which have not properly disable indy for them yet:

  • GraphQL v20: Was an easy fix, fix included in this PR
  • Reactor, Finagle and InfluxDB: disabled via this PR and will be added to Indy module migration #11457

@open-telemetry/java-instrumentation-maintainers : Please add the testIndy label to this PR to verify that it actually fixes the tests

@JonasKunz JonasKunz mentioned this pull request Jun 13, 2024
Merged
@JonasKunz JonasKunz marked this pull request as ready for review June 13, 2024 12:02
@JonasKunz JonasKunz requested a review from a team June 13, 2024 12:02
@trask trask merged commit 9f11c4a into open-telemetry:main Jun 13, 2024
56 checks passed
@JonasKunz JonasKunz deleted the graphql-indy-fix branch June 17, 2024 07:18
@SylvainJuge SylvainJuge mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

Assignees
No one assigned
Labels
test indy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonasKunz @trask @laurit