Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAX-RS: add code.namespace and code.function attributes #2805

Merged
merged 4 commits into from
Apr 14, 2021

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Apr 14, 2021

No description provided.

Comment on lines 64 to 67
// If path based name is empty skip appending context path so that path based name would
// remain as an empty string for which we skip updating span name. Path base span name is
// empty when method and class don't have a jax-rs path annotation, this can happen when
// creating an "abort" span, see RequestContextHelper.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@trask trask merged commit d1ff1e1 into open-telemetry:main Apr 14, 2021
@laurit laurit deleted the jaxrs-code-namspace branch August 24, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants