Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate context into jdk http client callback #3719

Merged
merged 3 commits into from
Jul 30, 2021

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Jul 29, 2021

No description provided.

Comment on lines -60 to -65

// TODO: context not propagated to callback
@Override
boolean testErrorWithCallback() {
return false
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@trask trask merged commit 78a4126 into open-telemetry:main Jul 30, 2021
@laurit laurit deleted the jdk-http-client-context-callback branch August 24, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants