Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printMuzzleReferences gradle task #3808

Merged

Conversation

mateuszrzeszutek
Copy link
Member

Currently when you try to run the printMuzzleReferences task it fails with the following exception:

* What went wrong:
Execution failed for task ':printMuzzleReferences'.
> io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule: com.example.javaagent.instrumentation.DemoServlet3InstrumentationModule not a subtype

* Try:
Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':printMuzzleReferences'.
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:188)
// ...
Caused by: java.util.ServiceConfigurationError: io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule: com.example.javaagent.instrumentation.DemoServlet3InstrumentationModule not a subtype
        at io.opentelemetry.javaagent.muzzle.matcher.MuzzleGradlePluginUtil.printMuzzleReferences(MuzzleGradlePluginUtil.java:113)

I suppose that's because we're trying to load InstrumentationModule with the gradle classloader, not the instrumentation classloader.

@mateuszrzeszutek
Copy link
Member Author

@iNikem how to make that fix available? Should I bump the plugins' version by hand?

@iNikem
Copy link
Contributor

iNikem commented Aug 10, 2021

@iNikem how to make that fix available? Should I bump the plugins' version by hand?

Yes, for now this is the way

@trask
Copy link
Member

trask commented Aug 10, 2021

Yes, for now this is the way

yes? 😁

image

@trask trask merged commit bebb877 into open-telemetry:main Aug 10, 2021
@mateuszrzeszutek mateuszrzeszutek deleted the fix-printMuzzleReferences-task branch August 11, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants