Start a CONSUMER span for Kafka poll(); and refactor spring-kafka... #4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
trask
approved these changes
Sep 8, 2021
...1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/kafkaclients/Timer.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/io/opentelemetry/javaagent/instrumentation/kafkaclients/ReceivedRecords.java
Outdated
Show resolved
Hide resolved
Yeah, definitely - I'll start working on the next part soon, we should definitely get it merged before the next release. |
|
Thanks @mateuszrzeszutek, were you able to make any progress on the next part? I think I am maybe seeing the disjointed consumer in an downstream Lightstep alpha release. |
|
@arm-chair does lightstep backend support links? if so you should be seeing the consumer linked to the producer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so that it has 1 batch receive span + 1 batch process span. This basically implements this idea: #3922 (comment) (well, a part of it).
The process CONSUMER span is not a child of the receive CONSUMER span yet (spec says it should be) because successive CONSUMERs are suppressed; but I'm planning to introduce a new suppression strategy for consumer spans in the next PR (separate span keys for receive an process).
This PR is split into 2 commits: the first contains just
kafka-clientschanges, the second justspring-kafkachanges. Maybe that'll help reviewing it.