Add functionality to generate API changes #4285
Conversation
iNikem
requested review from
anuraaga,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
conventions/src/main/kotlin/otel.japicmp-conventions.gradle.kts
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,2 @@ | |||
| Comparing source compatibility of against | |||
| No changes. | |||
There was a problem hiding this comment.
does this mean that this has no non-internal public classes/methods?
There was a problem hiding this comment.
This means that it did not change since the last release. At least I read id this way.
There was a problem hiding this comment.
Was this marked stable in a previous release, then?
There was a problem hiding this comment.
The gradle code is supposed to generate the full API in the case where there is no previously published stable release. If it's not doing that, then there might be something amiss without how the porting over from the java repo happened.
There was a problem hiding this comment.
Having a baseline of the API can be useful when looking at the first official stable release, as a documentation of the actual API that is now stable, rather than just seeing "no changes".
There was a problem hiding this comment.
I see. And under which folder such full API listing should live? I suspect not under "current vs latest"?
There was a problem hiding this comment.
I removed my support for unstable versions and also removed this diffs, as they don't make sense for now.
There was a problem hiding this comment.
I see. And under which folder such full API listing should live? I suspect not under "current vs latest"?
I think it would belong there if the 'current' has been marked stable in the current snapshot. It's a description of what you're preparing to release as a new stable API.
There was a problem hiding this comment.
I see. And under which folder such full API listing should live? I suspect not under "current vs latest"?
I think it would belong there if the 'current' has been marked stable in the current snapshot. It's a description of what you're preparing to release as a new stable API.
Got it, makes sense. So we will add that API list when we are ready to declare it stable.
Co-authored-by: John Watson <jkwatson@gmail.com>
Closes #4116
Almost verbatim copy from opentelemetry-java repo