Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Quarkus correlation #4883

Merged
merged 10 commits into from
Dec 13, 2021
Merged

Fix Quarkus correlation #4883

merged 10 commits into from
Dec 13, 2021

Conversation

trask
Copy link
Member

@trask trask commented Dec 13, 2021

Correlation was getting lost between netty/vertx (request) and quarkus/jax-rs (controller).

The fix is one line (I will highlight it with a review comment).

The PR also adds a smoke test image for Quarkus and a (currently ignored) smoke test.

Will send follow-up PR once smoke test image is published to enable the test.

Resolved #2493

"org.eclipse.jetty.util.thread.ReservedThreadExecutor",
"org.glassfish.grizzly.threadpool.GrizzlyExecutorService",
"org.jboss.threads.EnhancedQueueExecutor",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is the fix

Comment on lines -1 to -9
/*
* This file was generated by the Gradle 'init' task.
*
* The settings file is used to specify which projects to include in your build.
*
* Detailed information about configuring a multi-project build in Gradle can be found
* in the user manual at https://docs.gradle.org/6.6/userguide/multi_project_builds.html
*/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this to match the other smoke test settings.gradle files

Collection<ExportTraceServiceRequest> traces = waitForTraces()

then:
countSpansByName(traces, '/hello') == 1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without the fix, the SERVER span name is / b/c the correlation is lost between the SERVER span and the JAX-RS routing instrumentation, so the SERVER span name cannot be updated

@trask trask merged commit d930971 into open-telemetry:main Dec 13, 2021
@trask trask deleted the fix-quarkus-correlation branch December 13, 2021 17:26
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
* Fix Quarkus correlation

* Add Quarkus smoke test image

* Add Quarkus smoke test

* Fix permission on gradlew

* Update to gradle 7.3.1

* Fix Jib build

* Bump compilation to Java 11

* Better comment

* Fix comment placement

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarkus Netty broken traces on Kubernetes
4 participants