Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HttpRouteHolder in spring-webflux instrumentation #5239

Conversation

mateuszrzeszutek
Copy link
Member

Part of #442

@mateuszrzeszutek mateuszrzeszutek requested a review from a team January 26, 2022 13:42
Comment on lines +62 to +63
public static void updateHttpRoute(
Context context, HttpRouteSource source, @Nullable String httpRoute) {
Copy link
Member

@trask trask Jan 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think this will be used by other instrumentations? also, wondering if HttpRouteGetter0(?) would be more general for this case, which takes Context but no other args, then could use (non-capturing) simple lambda context -> httpRoute in this case (though this requires naming, so ...). or maybe Consumer<Context>? sorry for just throwing random ideas here, I don't have any strong opinions on this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few instrumentations that would make use of this method: ratpack, restlet. I thought that just passing the string would be the simplest solution in this case (and there's no naming problems with just passing a string 😄 ).

@mateuszrzeszutek mateuszrzeszutek merged commit 16335a0 into open-telemetry:main Jan 28, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the http-route-spring-webflux branch January 28, 2022 09:07
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants