Fix serialization fo quartz JobExecutionContext

instrumentation/quartz-2.0/library/src/main/java/io/opentelemetry/instrumentation/quartz/v2_0/TracingJobListener.java

@@ -7,13 +7,17 @@
 
 import io.opentelemetry.context.Context;
 import io.opentelemetry.context.Scope;
+import io.opentelemetry.instrumentation.api.field.VirtualField;
 import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
 import org.quartz.JobExecutionContext;
 import org.quartz.JobExecutionException;
 import org.quartz.JobListener;
 
 final class TracingJobListener implements JobListener {
 
+  private static final VirtualField<JobExecutionContext, ContextAndScope> contextVirtualField =
+      VirtualField.find(JobExecutionContext.class, ContextAndScope.class);
+
   private final Instrumenter<JobExecutionContext, Void> instrumenter;
 
   TracingJobListener(Instrumenter<JobExecutionContext, Void> instrumenter) {
@@ -38,31 +42,44 @@ public void jobToBeExecuted(JobExecutionContext job) {
     }
 
     Context context = instrumenter.start(parentCtx, job);
-    job.put(Context.class, context);
 
     // Listeners are executed synchronously on the same thread starting here.
     // https://github.com/quartz-scheduler/quartz/blob/quartz-2.0.x/quartz/src/main/java/org/quartz/core/JobRunShell.java#L180
     // However, if a listener before this one throws an exception in wasExecuted, we won't be
     // executed. Library instrumentation users need to make sure other listeners don't throw
     // exceptions.
     Scope scope = context.makeCurrent();
-    job.put(Scope.class, scope);
+    contextVirtualField.set(job, new ContextAndScope(context, scope));
   }
 
   @Override
   public void jobWasExecuted(JobExecutionContext job, JobExecutionException error) {
-    Scope scope = (Scope) job.get(Scope.class);
-    if (scope != null) {
-      scope.close();
-    }
-
-    Context context = (Context) job.get(Context.class);
-    if (context == null) {
+    ContextAndScope contextAndScope = contextVirtualField.get(job);
+    if (contextAndScope == null) {
       // Would only happen if we didn't start a span (maybe a previous joblistener threw an
       // exception before ours could process the start event).
       return;
     }
 
-    instrumenter.end(context, job, null, error);
+    contextAndScope.closeScope();
+    instrumenter.end(contextAndScope.getContext(), job, null, error);
+  }
+
+  private static final class ContextAndScope {
+    private final Context context;
+    private final Scope scope;
+
+    ContextAndScope(Context context, Scope scope) {
+      this.context = context;
+      this.scope = scope;
+    }
+
+    Context getContext() {
+      return context;
+    }
+
+    void closeScope() {
+      scope.close();
+    }
   }
 }

instrumentation/quartz-2.0/testing/src/main/java/io/opentelemetry/instrumentation/quartz/v2_0/AbstractQuartzTest.java

@@ -14,6 +14,9 @@
 import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
 import io.opentelemetry.sdk.trace.data.StatusData;
 import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.io.ObjectOutputStream;
 import java.util.Properties;
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeAll;
@@ -119,6 +122,12 @@ public static class SuccessfulJob implements Job {
     @Override
     public void execute(JobExecutionContext context) {
       GlobalOpenTelemetry.getTracer("jobtracer").spanBuilder("child").startSpan().end();
+      // ensure that JobExecutionContext is serializable
+      try {
+        new ObjectOutputStream(new ByteArrayOutputStream()).writeObject(context);
+      } catch (IOException e) {
+        throw new IllegalStateException(e);
+      }
     }
   }