Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix triggering of reverse name lookup #5297

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Fix triggering of reverse name lookup #5297

merged 3 commits into from
Feb 3, 2022

Conversation

trask
Copy link
Member

@trask trask commented Feb 2, 2022

Resolves #5295

@trask trask marked this pull request as ready for review February 3, 2022 00:22
@trask trask requested a review from a team February 3, 2022 00:22
Copy link
Contributor

@laurit laurit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RabbitChannelNetAttributesGetter, RabbitReceiveNetAttributesGetter and ReactorNettyHttpClientAttributesGetter might have the same issue.

@@ -29,9 +29,6 @@ public final String peerName(REQUEST request, @Nullable RESPONSE response) {
if (address == null) {
return null;
}
if (address.getAddress() != null) {
return address.getAddress().getHostName();
}
return address.getHostString();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe getHostString may return ip address. I hope spec is ok with this, if it isn't I guess we could compare it with getHostAddress and return null in case they match.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trask
Copy link
Member Author

trask commented Feb 3, 2022

RabbitChannelNetAttributesGetter, RabbitReceiveNetAttributesGetter and ReactorNettyHttpClientAttributesGetter might have the same issue.

thx! I'll fix those in a follow-up, since PR builds for those should be faster than PR builds on this one which touches core classes

@trask trask merged commit 3d0ebce into open-telemetry:main Feb 3, 2022
@trask trask deleted the fix-dns-lookup branch February 3, 2022 16:39
@trask trask changed the title Fix triggering of DNS lookup Fix triggering of reverse name lookup Feb 18, 2022
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
* Fix triggering of DNS lookup

* Update test

* Update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10s latency introduced when no external network connectivity
5 participants