Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max measurements to Micrometer Timer & DistributionSummary #5303

Merged

Conversation

mateuszrzeszutek
Copy link
Member

Fixes one of the issues discovered in #5292

@mateuszrzeszutek mateuszrzeszutek requested a review from a team February 3, 2022 15:38

// when
Metrics.globalRegistry.remove(timer);
Thread.sleep(10); // give time for any inflight metric export to be received
Copy link
Contributor

@anuraaga anuraaga Feb 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be able to remove this after #5314 I think

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing there may still be a tiny window while the metric sdk is still collecting metrics but before it has sent them to the metric exporter(?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At time of writing, that PR was causing clearData to first flush the metrics SDK. But realized it's not necessary or helpful in most tests so changed it back, so indeed this comment is now invalid

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i c, it flushed the full collection cycle, not just the export? that does seem useful for all of these micrometer unregister tests that we have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants