Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code attributes to spring-scheduling spans #5306

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Add code attributes to spring-scheduling spans #5306

merged 1 commit into from
Feb 8, 2022

Conversation

trask
Copy link
Member

@trask trask commented Feb 3, 2022

Motivation is that these spans currently have no attributes, so there's no way to suppress them via an attribute-based sampler.

Similar was done for Quartz in #4332

@trask trask requested a review from a team February 3, 2022 20:59
@trask trask merged commit a0f3ad7 into open-telemetry:main Feb 8, 2022
@trask trask deleted the add-code-attributes-to-spring-scheduling branch February 8, 2022 01:31
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants