Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set the http.route attribute in JSF instrumentations by default #5819

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

mateuszrzeszutek
Copy link
Member

..., but still override the server span name.

Resolves #5753

@mateuszrzeszutek mateuszrzeszutek requested a review from a team April 13, 2022 12:55
@trask trask merged commit 4d34d90 into open-telemetry:main Apr 14, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the jsf-http-route branch April 14, 2022 16:11
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
open-telemetry#5819)

* Do not set the http.route attribute in JSF instrumentations by default

* code review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http_server_duration_bucket generates high cardinality metrics
2 participants