Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak naming of spring autoconfigure and starter modules #6453

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

mateuszrzeszutek
Copy link
Member

Resolves #1285

@mateuszrzeszutek mateuszrzeszutek requested a review from a team August 10, 2022 12:52
Comment on lines +6 to +7
// Name the Spring Boot modules in accordance with https://docs.spring.io/spring-boot/docs/current/reference/html/features.html#features.developing-auto-configuration.custom-starter
base.archivesName.set("opentelemetry-spring-boot")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename the directory instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could -- I just thought that a directory named just spring-boot would be a tad more confusing than spring-boot-autoconfigure when you look at what the spring dir contains

@trask trask merged commit 5862ace into open-telemetry:main Aug 16, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the naming-spring-starters branch August 16, 2022 07:19
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweak naming of spring instrumentation modules
3 participants