Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode version in library instrumentations' package names #7764

Conversation

mateuszrzeszutek
Copy link
Member

Another part of #932

In this PR I changed all the library instrumentation packages -- these are breaking changes, so I figured the earlier we do this the less painful it'll be to the users. I know that at least some of them are actively used, so we'll need to spell this out in the release notes.

@mateuszrzeszutek mateuszrzeszutek requested a review from a team February 8, 2023 16:33
@trask
Copy link
Member

trask commented Feb 9, 2023

can you add the list of renames in the description so I can copy-paste in the release notes?

@trask trask added this to the v1.23.0 milestone Feb 9, 2023
@mateuszrzeszutek
Copy link
Member Author

* `io.opentelemetry.instrumentation.apachedbcp.ApacheDbcpTelemetry` was renamed to `io.opentelemetry.instrumentation.apachedbcp.v2_0.ApacheDbcpTelemetry`
* `io.opentelemetry.instrumentation.c3p0.C3p0Telemetry` was renamed to `io.opentelemetry.instrumentation.c3p0.v0_9.C3p0Telemetry`
* `io.opentelemetry.instrumentation.graphql.GraphQLTelemetry` was renamed to `io.opentelemetry.instrumentation.graphql.v12_0.GraphQLTelemetry`
* `io.opentelemetry.instrumentation.guava.GuavaAsyncOperationEndStrategy` was renamed to `io.opentelemetry.instrumentation.guava.v10_0.GuavaAsyncOperationEndStrategy`
* `io.opentelemetry.instrumentation.hikaricp.HikariTelemetry` was renamed to `io.opentelemetry.instrumentation.hikaricp.v3_0.HikariTelemetry`
* `io.opentelemetry.instrumentation.kafkaclients.KafkaTelemetry` was renamed to `io.opentelemetry.instrumentation.kafkaclients.v2_6.KafkaTelemetry`
* `io.opentelemetry.instrumentation.oracleucp.OracleUcpTelemetry` was renamed to `io.opentelemetry.instrumentation.oracleucp.v11_2.OracleUcpTelemetry`
* `io.opentelemetry.instrumentation.ratpack.RatpackTelemetry` was renamed to `io.opentelemetry.instrumentation.ratpack.v1_7.RatpackTelemetry`
* `io.opentelemetry.instrumentation.reactor.ContextPropagationOperator` was renamed to `io.opentelemetry.instrumentation.reactor.v3_1.ContextPropagationOperator`
* `io.opentelemetry.instrumentation.viburdbcp.ViburTelemetry` was renamed to `io.opentelemetry.instrumentation.viburdbcp.v11_0.ViburTelemetry`

@mateuszrzeszutek mateuszrzeszutek force-pushed the library-instrumentation-package-names branch from ea78e59 to b5c0b47 Compare February 10, 2023 11:51
@mateuszrzeszutek mateuszrzeszutek force-pushed the library-instrumentation-package-names branch from b5c0b47 to 04bdf1a Compare February 13, 2023 10:13
@trask trask enabled auto-merge (squash) February 14, 2023 20:05
@trask trask merged commit 4fd52c5 into open-telemetry:main Feb 14, 2023
@mateuszrzeszutek mateuszrzeszutek deleted the library-instrumentation-package-names branch February 15, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants