-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve pulsar instrumentation #8007
Conversation
cc @tjiuming |
it creates a new |
...ain/java/io/opentelemetry/javaagent/instrumentation/pulsar/v2_8/telemetry/PulsarRequest.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/javaagent/instrumentation/pulsar/v2_8/telemetry/PulsarSingletons.java
Outdated
Show resolved
Hide resolved
.addAttributesExtractor( | ||
MessagingAttributesExtractor.create(getter, MessageOperation.RECEIVE)) | ||
NetClientAttributesExtractor.create(new PulsarNetClientAttributesGetter())) | ||
.buildConsumerInstrumenter(MessageTextMapGetter.INSTANCE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably use the common messagingReceiveInstrumentationEnabled
flag
.buildConsumerInstrumenter(MessageTextMapGetter.INSTANCE); | |
.setEnabled(ExperimentalConfig.get().messagingReceiveInstrumentationEnabled()) | |
.buildConsumerInstrumenter(MessageTextMapGetter.INSTANCE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't mind I would work on this in a subsequent PR. As far as I understand using the messagingReceiveInstrumentationEnabled
isn't enough to make it comply with spec, it should also use span link.
message.type
with experimental attributemessaging.pulsar.message.type
,message.type
is from rpc semantic conventionsnet.sock.peer.addr
that was filled with broker url withnet.peer.name
andnet.peer.port