Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate InetSocketAddressNetServerAttributesGetter and move its met… #8341

Conversation

mateuszrzeszutek
Copy link
Member

…hods to the interface

I think at some point I mentioned that I had thought about making the HTTP semconv getter extend the net getters (and URL getters, user agent getters etc. once we migrate to ECS names) to mimic the way the HTTP semconv "extends" (includes attributes from) other semantic conventions. This PR is a prerequisite for that -- but it is useful on its own, I think, as it simplifies the story of implementing the net getters by removing the abstract InetSocketAddress class.

Client side will be included in the next PR.

@mateuszrzeszutek mateuszrzeszutek requested a review from a team April 24, 2023 11:48
@mateuszrzeszutek mateuszrzeszutek merged commit c4ee60d into open-telemetry:main May 29, 2023
@mateuszrzeszutek mateuszrzeszutek deleted the deprecate-InetSocketAddressNetServerAttributesGetter branch May 29, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants