-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit both old and new metrics under dup setting #9320
Conversation
...c/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/TemporaryMetricsView.java
Outdated
Show resolved
Hide resolved
createDurationHistogram( | ||
meter, "http.client.request.duration", "The duration of the outbound HTTP request"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you'll also need to change the condition on which the advice is applied: right now the buckets are not set if emitOldHttpSemconv
is true, and that does not really make sense when we split the histograms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(just making sure: missing commit?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
related to open-telemetry/opentelemetry-dotnet#4802 (comment)