Spring webflux: add user spans as children of the controller span #9572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Sep 28, 2023
| @@ -52,7 +52,6 @@ public final class HttpServerTestOptions { | |||
| Predicate<ServerEndpoint> hasHandlerSpan = unused -> false; | |||
| Predicate<ServerEndpoint> hasResponseSpan = unused -> false; | |||
| Predicate<ServerEndpoint> hasErrorPageSpans = unused -> false; | |||
| Predicate<ServerEndpoint> hasHandlerAsControllerParentSpan = unused -> true; | |||
Comment on lines
77
to
81
| options.setHasHandlerAsControllerParentSpan(unused -> false); | ||
| // TODO (trask) it seems like in this case ideally the controller span (which ends when the | ||
| // Mono that the controller returns completes) should end before the server span (which needs | ||
| // the result of the Mono) | ||
| options.setVerifyServerSpanEndTime(false); |
There was a problem hiding this comment.
had to restore disabling end time verification because latest dep tests didn't pass
laurit
force-pushed
the
webflux-controller-parent
branch
from
cadb472
to
eeeb921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9495
Currently spans that should be child spans of the controller appear as child spans of the server span.