Returns invalid traceflags for a bad string parse instead of throwing… #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
anuraaga
force-pushed
the
traceflags-invalid
branch
from
70fa3a2
to
f6aaef9
Compare
jkwatson
reviewed
Feb 26, 2021
| return TraceId.isValid(getTraceId()) && SpanId.isValid(getSpanId()); | ||
| return TraceId.isValid(getTraceId()) | ||
| && SpanId.isValid(getSpanId()) | ||
| && getTraceFlags().isValid(); |
There was a problem hiding this comment.
this is a change from the specification, I believe, which says that the SpanContext is valid iff the spanid and traceid are valid, but doesn't mention trace flags.
|
I think introducing the concept of invalid trace flags is something that should go through the spec. Compare also open-telemetry/opentelemetry-specification#753 |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… an exception.
Supercedes #2869
This removes the one and only place in the API that still declares it throws an exception. It avoids returning
null, as in #2869, to reduce the chance of problems with usage of the API, an invalid traceflags should be handled by a propagator. But in the chance it's not handled, it will act as an empty traceflags and not cause crashes.This is a behavior change which I agree with @bogdandrutu we need to make now or never since, i.e. a propagator that relied on the exceptions to handle invalid would not do so anymore if we removed them later. As
TraceFlagspresumably has no real use case outside of the w3c propagator, I'm comfortable with squeezing this into the release but open to thoughts.