Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zipkin exporter: Serialize EventData attributes as JSON #4934

Merged
merged 5 commits into from
Nov 21, 2022

Conversation

breedx-splk
Copy link
Contributor

Resolves #4859.

@breedx-splk breedx-splk requested a review from a team November 10, 2022 22:51
@breedx-splk breedx-splk changed the title Zipkin exporter: Serrialize EventData attributes as JSON Zipkin exporter: Serialize EventData attributes as JSON Nov 10, 2022
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 91.00% // Head: 91.02% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (23425af) compared to base (e814602).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4934      +/-   ##
============================================
+ Coverage     91.00%   91.02%   +0.01%     
- Complexity     4839     4847       +8     
============================================
  Files           546      547       +1     
  Lines         14439    14455      +16     
  Branches       1395     1396       +1     
============================================
+ Hits          13140    13157      +17     
+ Misses          894      893       -1     
  Partials        405      405              
Impacted Files Coverage Δ
...lemetry/exporter/zipkin/EventDataToAnnotation.java 100.00% <100.00%> (ø)
...y/exporter/zipkin/OtelToZipkinSpanTransformer.java 92.00% <100.00%> (+0.10%) ⬆️
...y/exporter/internal/marshal/CodedOutputStream.java 69.82% <0.00%> (-1.19%) ⬇️
...emconv/resource/attributes/ResourceAttributes.java 100.00% <0.00%> (ø)
...try/exporter/zipkin/ZipkinSpanExporterBuilder.java 97.72% <0.00%> (ø)
...exporter/jaeger/JaegerGrpcSpanExporterBuilder.java 80.64% <0.00%> (ø)
...opentelemetry/opentracingshim/SpanBuilderShim.java 89.14% <0.00%> (+0.86%) ⬆️
...ava/io/opentelemetry/opentracingshim/SpanShim.java 88.49% <0.00%> (+0.88%) ⬆️
...ava/io/opentelemetry/sdk/internal/RateLimiter.java 100.00% <0.00%> (+5.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! Couple of small comments.

@jack-berg jack-berg merged commit e61d7c8 into open-telemetry:main Nov 21, 2022
dmarkwat pushed a commit to dmarkwat/opentelemetry-java that referenced this pull request Dec 30, 2022
…ry#4934)

* serialize EventData attributes to json

* remove import

* fix test

* address code review comments.

* safety first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zipkin exporter does not serialize event attributes into a JSON string (the spec says it MUST)
3 participants