Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing createTracerShim function #4988

Merged
merged 3 commits into from
Dec 13, 2022

Conversation

cuichenli
Copy link
Contributor

fix #4909

Signed-off-by: Cuichen Li <cuichli@cisco.com>
@cuichenli cuichenli requested a review from a team November 25, 2022 09:00
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 91.24% // Head: 91.23% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (6b52148) compared to base (ab31828).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4988      +/-   ##
============================================
- Coverage     91.24%   91.23%   -0.02%     
+ Complexity     4886     4882       -4     
============================================
  Files           552      552              
  Lines         14440    14422      -18     
  Branches       1379     1375       -4     
============================================
- Hits          13176    13158      -18     
  Misses          876      876              
  Partials        388      388              
Impacted Files Coverage Δ
.../aggregator/DoubleExponentialHistogramBuckets.java 87.27% <ø> (-0.77%) ⬇️
...opentelemetry/opentracingshim/OpenTracingShim.java 100.00% <100.00%> (ø)
...opentelemetry/opentracingshim/SpanBuilderShim.java 94.78% <100.00%> (+0.98%) ⬆️
...ava/io/opentelemetry/opentracingshim/SpanShim.java 91.07% <100.00%> (+0.80%) ⬆️
...gregator/DoubleExponentialHistogramAggregator.java 100.00% <100.00%> (ø)
...telemetry/sdk/trace/export/BatchSpanProcessor.java 91.03% <0.00%> (-1.38%) ⬇️
...metry/sdk/logs/export/BatchLogRecordProcessor.java 89.36% <0.00%> (-0.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg
Copy link
Member

PTAL @carlosalberto, thanks!

@carlosalberto
Copy link
Contributor

So sorry, somehow I missed this PR :( I'm fine with adding this overload - that being said, the related issue is about specifically adding:

createTracerShim(TracerProvider tracerProvider, OpenTracingPropagators propagators)

@cuichenli
Copy link
Contributor Author

thanks @carlosalberto , i have updated accordingly

@carlosalberto
Copy link
Contributor

@cuichenli Thanks a lot!

@jkwatson jkwatson merged commit 4eb968e into open-telemetry:main Dec 13, 2022
dmarkwat pushed a commit to dmarkwat/opentelemetry-java that referenced this pull request Dec 30, 2022
* add missing createTracerShim function

Signed-off-by: Cuichen Li <cuichli@cisco.com>

* update based on comment

Signed-off-by: Cuichen Li <cuichli@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenTracing Shim: Align Shim Layer creation arguments
4 participants