Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop delta metrics in prometheus exporter #5062

Merged

Conversation

jack-berg
Copy link
Member

Resolves #5015.

@jack-berg jack-berg requested a review from a team December 22, 2022 19:19
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 91.24% // Head: 91.22% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (33b1cba) compared to base (16a02b2).
Patch coverage: 77.77% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5062      +/-   ##
============================================
- Coverage     91.24%   91.22%   -0.03%     
- Complexity     4883     4890       +7     
============================================
  Files           553      553              
  Lines         14449    14454       +5     
  Branches       1379     1380       +1     
============================================
+ Hits          13184    13185       +1     
- Misses          878      880       +2     
- Partials        387      389       +2     
Impacted Files Coverage Δ
.../opentelemetry/exporter/prometheus/Serializer.java 87.93% <71.42%> (-0.41%) ⬇️
...ntelemetry/exporter/prometheus/PrometheusType.java 90.90% <100.00%> (-0.76%) ⬇️
...metry/sdk/metrics/export/PeriodicMetricReader.java 87.14% <0.00%> (-2.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit e898479 into open-telemetry:main Dec 27, 2022
dmarkwat pushed a commit to dmarkwat/opentelemetry-java that referenced this pull request Dec 30, 2022
* Drop delta metrics in prometheus exporter

* Adjust switch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus exporter handles delta metrics differently from the current spec
2 participants