Add shutdown / close to OpenTelemetrySdk #5100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 91.05% // Head: 91.06% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5100 +/- ##
=========================================
Coverage 91.05% 91.06%
+ Complexity 4889 4888 -1
=========================================
Files 553 553
Lines 14467 14468 +1
Branches 1388 1388
=========================================
+ Hits 13173 13175 +2
Misses 896 896
+ Partials 398 397 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -390,6 +375,10 @@ public AutoConfiguredOpenTelemetrySdk build() { | |||
| .setPropagators(propagators); | |||
|
|
|||
| openTelemetrySdk = sdkBuilder.build(); | |||
|
|
|||
| if (registerShutdownHook) { | |||
| Runtime.getRuntime().addShutdownHook(new Thread(openTelemetrySdk::shutdown)); | |||
There was a problem hiding this comment.
Shouldn't that be close instead of shutdown?
Suggested change
| Runtime.getRuntime().addShutdownHook(new Thread(openTelemetrySdk::shutdown)); | |
| Runtime.getRuntime().addShutdownHook(new Thread(openTelemetrySdk::close)); |
mateuszrzeszutek
approved these changes
Jan 10, 2023
jkwatson
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5086.