Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close method to MetricReader #5109

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

jack-berg
Copy link
Member

Working #5090 and noticed that MetricReader didn't implement Closeable.

Adjusted MetricReader to extend Closeable, and added a default implementation so the change is backwards compatible. Ran into some issues where japicmp was flagging a false positive that the change was breaking. Ended up needing to dive deeper into the japicmp gradle plugin than I wanted to to discover the source of the bug, but along the way found some better ways to organize our config which make it easier to comprehend.

@jack-berg jack-berg requested a review from a team January 10, 2023 22:00
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 91.06% // Head: 91.06% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (1f3bae9) compared to base (50e7a17).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5109   +/-   ##
=========================================
  Coverage     91.06%   91.06%           
- Complexity     4885     4886    +1     
=========================================
  Files           553      553           
  Lines         14463    14465    +2     
  Branches       1388     1388           
=========================================
+ Hits          13171    13173    +2     
  Misses          895      895           
  Partials        397      397           
Impacted Files Coverage Δ
...etry/exporter/prometheus/PrometheusHttpServer.java 80.73% <ø> (ø)
...opentelemetry/sdk/metrics/export/MetricReader.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg merged commit 1915f1f into open-telemetry:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants