Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the semantic conventions to v1.17.0 #5134

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

jkwatson
Copy link
Contributor

@jkwatson jkwatson commented Jan 18, 2023

Note: this is the first time in a while where we have keys that have changed, but the names of the attributes have not. We don't have a way to deal with this particular change to make it non-breaking for people who might be using them.

Also, I think I caught all the deprecated items, but if I missed some, please call them out!

@jkwatson jkwatson requested a review from a team January 18, 2023 03:47
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 91.10% // Head: 91.09% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (7cdedc4) compared to base (1e4a7be).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5134      +/-   ##
============================================
- Coverage     91.10%   91.09%   -0.02%     
  Complexity     4901     4901              
============================================
  Files           549      549              
  Lines         14497    14497              
  Branches       1390     1390              
============================================
- Hits          13208    13206       -2     
- Misses          890      891       +1     
- Partials        399      400       +1     
Impacted Files Coverage Δ
...emconv/resource/attributes/ResourceAttributes.java 100.00% <ø> (ø)
...metry/sdk/metrics/export/PeriodicMetricReader.java 87.14% <0.00%> (-2.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked all the changed attributes, LGTM 👍

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added a note to talk about removal strategy in the SIG meeting this week. 👍🏻

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't take too close a look at this. I can if you think its necessary to feel comfortable merging.

@jkwatson jkwatson merged commit e25120a into open-telemetry:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants