Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marshal span status description without allocation #6423

Merged
merged 1 commit into from
May 3, 2024
Merged

Marshal span status description without allocation #6423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...ain/java/io/opentelemetry/exporter/internal/otlp/traces/SpanStatusStatelessMarshaler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import io.opentelemetry.exporter.internal.marshal.ProtoEnumInfo;
import io.opentelemetry.exporter.internal.marshal.Serializer;
import io.opentelemetry.exporter.internal.marshal.StatelessMarshaler;
import io.opentelemetry.exporter.internal.marshal.StatelessMarshalerUtil;
import io.opentelemetry.proto.trace.v1.internal.Status;
import io.opentelemetry.sdk.trace.data.StatusData;
import java.io.IOException;
Expand All @@ -24,20 +25,19 @@ final class SpanStatusStatelessMarshaler implements StatelessMarshaler<StatusDat
public void writeTo(Serializer output, StatusData status, MarshalerContext context)
throws IOException {
ProtoEnumInfo protoStatusCode = toProtoSpanStatus(status);
byte[] descriptionUtf8 = context.getData(byte[].class);

output.serializeString(Status.MESSAGE, descriptionUtf8);
output.serializeStringWithContext(Status.MESSAGE, status.getDescription(), context);
output.serializeEnum(Status.CODE, protoStatusCode);
}

@Override
public int getBinarySerializedSize(StatusData status, MarshalerContext context) {
ProtoEnumInfo protoStatusCode = toProtoSpanStatus(status);
byte[] descriptionUtf8 = MarshalerUtil.toBytes(status.getDescription());
context.addData(descriptionUtf8);

int size = 0;
size += MarshalerUtil.sizeBytes(Status.MESSAGE, descriptionUtf8);
size +=
StatelessMarshalerUtil.sizeStringWithContext(
Status.MESSAGE, status.getDescription(), context);
size += MarshalerUtil.sizeEnum(Status.CODE, protoStatusCode);

return size;
Expand Down
Loading