Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: minor cleanup to pino ESM test #2241

Merged
merged 1 commit into from
May 27, 2024

Conversation

trentm
Copy link
Contributor

@trentm trentm commented May 25, 2024

The ESM tests are out of process so the setup done in
setupInstrumentationAndInitTestContext() isn't relevant.

The ESM tests are out of process so the setup done in
setupInstrumentationAndInitTestContext() isn't relevant.
@trentm trentm self-assigned this May 25, 2024
@trentm trentm requested a review from a team May 25, 2024 00:08
@github-actions github-actions bot requested a review from seemk May 25, 2024 00:08
@trentm
Copy link
Contributor Author

trentm commented May 25, 2024

@JamieDanielson poke, because you were last editing this test code. (I'm working on adding Logs Bridge support to instr-pino. I wanted to get this minor tweak in separate from my coming PR.)

No rush. I won't have my instr-pino Logs Bridge PR ready until next week.

Copy link

codecov bot commented May 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.38%. Comparing base (dfb2dff) to head (0d5cc8f).
Report is 142 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2241      +/-   ##
==========================================
- Coverage   90.97%   90.38%   -0.60%     
==========================================
  Files         146      148       +2     
  Lines        7492     7509      +17     
  Branches     1502     1573      +71     
==========================================
- Hits         6816     6787      -29     
- Misses        676      722      +46     

see 44 files with indirect coverage changes

@trentm trentm merged commit 27d6503 into open-telemetry:main May 27, 2024
16 checks passed
@trentm trentm deleted the tm-pino-esm-test-tweak branch May 27, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants