Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TraceIdRatioBasedSampler to calculate sampling threshold according to OTEP 235 #1391

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Sep 28, 2024

Computes the sampling threshold as defined in open-telemetry/opentelemetry-specification#4166.

See OTEP 235, Threshold = (1 - Probability) * 2**56.
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.56%. Comparing base (20bf3cf) to head (96bebeb).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1391      +/-   ##
============================================
- Coverage     73.56%   73.56%   -0.01%     
- Complexity     2672     2679       +7     
============================================
  Files           386      386              
  Lines          7650     7659       +9     
============================================
+ Hits           5628     5634       +6     
- Misses         2022     2025       +3     
Flag Coverage Δ
8.4 73.56% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/SDK/Trace/Sampler/TraceIdRatioBasedSampler.php 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20bf3cf...96bebeb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant