Adjust gauge StartTimeUnixNano description to accommodate sync gauges #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Jun 28, 2023
| // "StartTimeUnixNano" is ignored for all data points. | ||
| // A Gauge does not support different aggregation temporalities. | ||
| // However, its "StartTimeUnixNano" may follow the semantics of a temporality | ||
| // selection. E.g. "StartTimeUnixNano" may be the time of last collection when |
There was a problem hiding this comment.
There is no temporality for Gauge, what does temporality is delta mean in this text?
There was a problem hiding this comment.
This is meant to draft out how we might change the proto description text to accommodate this proposal to add a synchronous gauge instrument: open-telemetry/opentelemetry-specification#3540
The current iteration of the synchronous gauge proposal allows aggregation temporality selection to influence the start time of gauges.
|
Closing as the sync gauge PR went in a different direction that avoided changing the data model: open-telemetry/opentelemetry-specification#3540 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust gauge description to indicate that StartTimeUnixNano may be influenced by aggregation temporality.