Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiles: drop BuildIdKind #584

Merged
merged 4 commits into from
Sep 16, 2024
Merged

profiles: drop BuildIdKind #584

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
622b738
profiles: drop BuildIdKind
florianl Sep 10, 2024
0d9c71d
Merge branch 'main' into patch-5
tigrannajaryan Sep 12, 2024
ce9fb28
Merge branch 'main' into patch-5
tigrannajaryan Sep 16, 2024
a61d6d0
Merge branch 'main' into patch-5
tigrannajaryan Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions opentelemetry/proto/profiles/v1experimental/pprofextended.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,17 +271,6 @@ message Label {
int64 num_unit = 4; // Index into string table
}

// Indicates the semantics of the build_id field.
enum BuildIdKind {
// Linker-generated build ID, stored in the ELF binary notes.
BUILD_ID_LINKER = 0;
// Build ID based on the content hash of the binary. Currently no particular
// hashing approach is standardized, so a given producer needs to define it
// themselves and thus unlike BUILD_ID_LINKER this kind of hash is producer-specific.
// We may choose to provide a standardized stable hash recommendation later.
BUILD_ID_BINARY_HASH = 1;
}

// Describes the mapping of a binary in memory, including its address range,
// file offset, and metadata like build ID
message Mapping {
Expand All @@ -297,12 +286,6 @@ message Mapping {
// disk for the main binary and shared libraries, or virtual
// abstractions like "[vdso]".
int64 filename = 5; // Index into string table
// A string that uniquely identifies a particular program version
// with high probability. E.g., for binaries generated by GNU tools,
// it could be the contents of the .note.gnu.build-id field.
int64 build_id = 6; // Index into string table
// Specifies the kind of build id. See BuildIdKind enum for more details [optional]
BuildIdKind build_id_kind = 11;
florianl marked this conversation as resolved.
Show resolved Hide resolved
// References to attributes in Profile.attribute_table. [optional]
repeated uint64 attributes = 12;
// The following fields indicate the resolution of symbolic info.
Expand Down
Loading