adding python-snappy to setup.cfg

open-telemetry · Dec 22, 2020 · 26c9059 · 26c9059
1 parent 6cf2236
commit 26c9059
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/exporter/opentelemetry-exporter-prometheus-remote-write/README.rst b/exporter/opentelemetry-exporter-prometheus-remote-write/README.rst
@@ -48,7 +48,7 @@ Table of Contents
 
 Installation
 ------------
-Prerequisite
+Prerequisites
 ~~~~~~~~~~~~
 1. Install the snappy c-library
     **DEB**: ``sudo apt-get install libsnappy-dev``
@@ -59,9 +59,6 @@ Prerequisite
 
     **Windows**: ``pip install python_snappy-0.5-cp36-cp36m-win_amd64.whl``
 
-2. Install python-snappy
-    `pip install python-snappy`
-
 Exporter
 ~~~~~~~~
 

diff --git a/exporter/opentelemetry-exporter-prometheus-remote-write/setup.cfg b/exporter/opentelemetry-exporter-prometheus-remote-write/setup.cfg
@@ -43,7 +43,7 @@ install_requires =
     requests == 2.25.0
     opentelemetry-api == 0.17.dev0
     opentelemetry-sdk == 0.17.dev0
-
+    python-snappy >= 0.5.4
 [options.packages.find]
 where = src
 

diff --git a/...er-prometheus-remote-write/src/opentelemetry/exporter/prometheus_remote_write/__init__.py b/...er-prometheus-remote-write/src/opentelemetry/exporter/prometheus_remote_write/__init__.py
@@ -17,8 +17,8 @@
 from typing import Dict, Sequence
 
 import requests
-
 import snappy
+
 from opentelemetry.exporter.prometheus_remote_write.gen.remote_pb2 import (
     WriteRequest,
 )

diff --git a/tox.ini b/tox.ini
@@ -296,6 +296,8 @@ deps =
   httpretty
 
 commands_pre =
+  sudo apt-get install libsnappy-dev
+  pip install python-snappy
   python -m pip install {toxinidir}/opentelemetry-python-core/opentelemetry-api
   python -m pip install {toxinidir}/opentelemetry-python-core/opentelemetry-instrumentation
   python -m pip install {toxinidir}/opentelemetry-python-core/opentelemetry-sdk
@@ -356,6 +358,8 @@ changedir =
   tests/opentelemetry-docker-tests/tests
 
 commands_pre =
+  sudo apt-get install libsnappy-dev
+  pip install python-snappy
   pip install -e {toxinidir}/opentelemetry-python-core/opentelemetry-api \
               -e {toxinidir}/opentelemetry-python-core/opentelemetry-instrumentation \
               -e {toxinidir}/opentelemetry-python-core/opentelemetry-sdk \
@@ -373,8 +377,6 @@ commands_pre =
               -e {toxinidir}/instrumentation/opentelemetry-instrumentation-system-metrics \
               -e {toxinidir}/opentelemetry-python-core/exporter/opentelemetry-exporter-opencensus \
               -e {toxinidir}/exporter/opentelemetry-exporter-prometheus-remote-write
-  sudo apt-get install libsnappy-dev
-  pip install python-snappy
   docker-compose up -d
   python check_availability.py
 commands =