Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for new component: Baggage Span Processor #2428

Closed
MikeGoldsmith opened this issue Apr 16, 2024 · 0 comments · Fixed by #2436
Closed

Request for new component: Baggage Span Processor #2428

MikeGoldsmith opened this issue Apr 16, 2024 · 0 comments · Fixed by #2436

Comments

@MikeGoldsmith
Copy link
Member

Is your feature request related to a problem?
The Honeycomb distro currently provides a Span processor that takes items from the baggage and adds those items as attributes onto spans.

Describe the solution you'd like
We'd like to donate this code upstream if there's an interest from the community, the code is pretty minimal:
https://github.com/honeycombio/honeycomb-opentelemetry-python/blob/main/src/honeycomb/opentelemetry/baggage.py

Describe alternatives you've considered
Which alternative solutions or features have you considered?

Additional context
Add any other context about the feature request here.

codeboten added a commit to codeboten/opentelemetry-python-contrib that referenced this issue Apr 17, 2024
Fixes open-telemetry#2428

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
ocelotl pushed a commit that referenced this issue Apr 25, 2024
* new(opentelemetry-processor-baggage): add new component

Fixes #2428

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* add tests

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* update changelog

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* update component owners

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* lint

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* update license

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* fix lint

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* lint

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

* rename processors dir to processor

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant