Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of httpx 0.19.* #668

Closed
TomerHeber opened this issue Sep 8, 2021 · 2 comments
Closed

Allow usage of httpx 0.19.* #668

TomerHeber opened this issue Sep 8, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@TomerHeber
Copy link

TomerHeber commented Sep 8, 2021

httpx 0.19.0
opentelemetry-instrumentation-httpx 0.24b0

Steps to reproduce
Start the application.

What is the expected behavior?
No error messages.

What is the actual behavior?
DependencyConflict: requested: "httpx >= 0.18.0, < 0.19.0" but found: "httpx 0.19.0"

I'm wondering why opentelemetry-instrumentation-httpx is configured to support only 0.18.* and not anything above 0.19.*
If there are no concerns, could it allow 0.19.* as well?

https://github.com/open-telemetry/opentelemetry-python-contrib/blame/97e9f2f9ef6c775108ab30946a8668f64f37a4d9/instrumentation/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/package.py#L16

(Sorry. I opened it as a bug, but this is not a real bug).

@TomerHeber TomerHeber added the bug Something isn't working label Sep 8, 2021
@owais
Copy link
Contributor

owais commented Sep 9, 2021

If it works, we should enable it. PRs welcome :)

ocelotl added a commit to ocelotl/opentelemetry-python-contrib that referenced this issue Sep 9, 2021
@srikanthccv
Copy link
Member

Fixed in #866

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants