Refactoring custom header collection API for consistency #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/ashu658/opentelemetry-python-contrib into refactor-collect-custom-header-api
sanketmehta28
requested changes
Apr 20, 2022
.../opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware.py
Show resolved
Hide resolved
sanketmehta28
approved these changes
Apr 21, 2022
srikanthccv
reviewed
Apr 22, 2022
CHANGELOG.md
Outdated
| @@ -30,6 +30,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ([#999])(https://github.com/open-telemetry/opentelemetry-python-contrib/pull/999) | |||
| - `opentelemetry-instrumentation-tornado` Fix non-recording span bug | |||
| ([#999])(https://github.com/open-telemetry/opentelemetry-python-contrib/pull/999) | |||
| - Refactoring custom header collection API for consistency | |||
There was a problem hiding this comment.
Move this to unreleased section
srikanthccv
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing
add_custom_request_headerstocollect_custom_request_headers_attributesandadd_custom_response_headerstocollect_custom_response_headers_attributesfor making it consistent across ASGI, WSGI and tornado.Fixes #1025
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Running available unit tests to capture request and response headers.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.