-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate otlp_proto_grpc and otlp_proto_http in auto-instrumentation #1250
Changes from 12 commits
7f6a041
da269f5
922b349
be7dce8
f96e768
6cbf14d
ea4e189
612c86d
67b07e9
7c9b724
626289f
34f76ac
32c3b31
1b89f29
2aab7ff
448dff7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,6 +57,7 @@ The command supports the following configuration options as CLI arguments and en | |
|
||
|
||
* ``--traces_exporter`` or ``OTEL_TRACES_EXPORTER`` | ||
* ``--metrics_exporter`` or ``OTEL_METRICS_EXPORTER`` | ||
|
||
Used to specify which trace exporter to use. Can be set to one or more of the well-known exporter | ||
names (see below). | ||
|
@@ -71,13 +72,14 @@ Well known trace exporter names: | |
- jaeger_proto | ||
- jaeger_thrift | ||
- opencensus | ||
- otlp | ||
- otlp_proto_grpc | ||
- otlp_proto_http | ||
- zipkin_json | ||
- zipkin_proto | ||
- otlp | ||
- otlp_proto_grpc (`deprecated`) | ||
- otlp_proto_http (`deprecated`) | ||
Comment on lines
+78
to
+79
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should not recommend using this, as the defined way in OTel to configure the protocol is with the other env vars, and to avoid conflicts. In future versions, we may also remove these options (though it's a breaking change). |
||
|
||
``otlp`` is an alias for ``otlp_proto_grpc``. | ||
Note: The default transport protocol for ``otlp`` is gRPC. | ||
HTTP is currently supported for traces only, and should be set using ``OTEL_EXPORTER_OTLP_TRACES_PROTOCOL=http/protobuf`` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suggest not using the more general way of |
||
|
||
* ``--id-generator`` or ``OTEL_PYTHON_ID_GENERATOR`` | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to Unreleased section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix this