Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Urllib instrumentation - Add status code to span if not None #1430

Conversation

shalevr
Copy link
Member

@shalevr shalevr commented Nov 4, 2022

Description

Add test_response_code_none test that verify it
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Add the status code to span only if not None.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • tox -e test-instrumentation-urllib

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Add test_response_code_none test that verify it
@shalevr shalevr requested a review from a team November 4, 2022 18:50
@shalevr shalevr marked this pull request as draft November 4, 2022 18:52
@shalevr shalevr changed the title Add status code to span if not None Fix Urllib instrumentation - Add status code to span if not None Nov 4, 2022
@shalevr shalevr marked this pull request as ready for review November 4, 2022 20:11
@srikanthccv srikanthccv merged commit f994e14 into open-telemetry:main Nov 5, 2022
saartochner-lumigo pushed a commit to lumigo-io/opentelemetry-python-contrib that referenced this pull request Nov 13, 2022
saartochner-lumigo pushed a commit to lumigo-io/opentelemetry-python-contrib that referenced this pull request Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants