Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pymongo capture collection name #1555

Merged
merged 14 commits into from
Jan 11, 2023

Conversation

avzis
Copy link
Contributor

@avzis avzis commented Dec 29, 2022

According to the specs -
mongodb should capture: "The collection being accessed within the database stated in db.name."
and save it in: db.mongodb.collection

Fixes #1539

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Added validation to the tests to verify that the property db.mongodb.collection is captured correctly

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

@avzis avzis marked this pull request as ready for review December 29, 2022 14:53
@avzis avzis requested a review from a team December 29, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pymongo is not collecting the property: db.mongodb.collection
3 participants